fix(module:dropdown): should always debouce before subscribe visibleC…

…hange$ (#237) close #234
NG-ZORRO · Sep 6, 2017 · 0180e1c · 0180e1c
1 parent 6b69cf9
commit 0180e1c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/src/components/dropdown/nz-dropdown-button.component.ts b/src/components/dropdown/nz-dropdown-button.component.ts
@@ -9,7 +9,6 @@ import {
   EventEmitter,
   AfterViewInit
 } from '@angular/core';
-import { debounceTime } from 'rxjs/operator/debounceTime';
 import { DropDownAnimation } from '../core/animation/dropdown-animations';
 import { NzDropDownDirective } from './nz-dropdown.directive';
 import { NzDropDownComponent } from './nz-dropdown.component';

diff --git a/src/components/dropdown/nz-dropdown.component.ts b/src/components/dropdown/nz-dropdown.component.ts
@@ -143,7 +143,7 @@ export class NzDropDownComponent implements OnInit, OnDestroy, AfterViewInit {
   }
 
   _startSubscribe(observable$: Observable<boolean>) {
-    this._subscription = observable$
+    this._subscription = debounceTime.call(observable$, 300)
       .subscribe(this._onVisibleChange)
   }
 
@@ -182,12 +182,10 @@ export class NzDropDownComponent implements OnInit, OnDestroy, AfterViewInit {
         return () => dispose();
       });
     }
-    const observable$ = debounceTime.call(
-      merge(
-        mouse$,
-        this.nzVisibleChange.asObservable()
-      )
-      , 300);
+    const observable$ = merge(
+      mouse$,
+      this.nzVisibleChange.asObservable()
+    );
     this._startSubscribe(observable$);
   }