fix(module:pagination): fix still show when total is 0 and nzHideOnSi…

…nglePage is true (#1583)
NG-ZORRO · Jun 2, 2018 · c5c33d0 · c5c33d0
1 parent 3bc2e90
commit c5c33d0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/components/pagination/nz-pagination.component.html b/components/pagination/nz-pagination.component.html
@@ -2,7 +2,7 @@
   <a class="ant-pagination-item-link" *ngIf="type!='page'"></a>
   <a *ngIf="type=='page'">{{page}}</a>
 </ng-template>
-<ng-container *ngIf="(nzHideOnSinglePage&&(lastIndex!=1))||!nzHideOnSinglePage">
+<ng-container *ngIf="(nzHideOnSinglePage&&(nzTotal>nzPageSize))||!nzHideOnSinglePage">
   <ul
     *ngIf="nzSimple"
     [class.ant-table-pagination]="nzInTable"

diff --git a/components/pagination/nz-pagination.spec.ts b/components/pagination/nz-pagination.spec.ts
@@ -236,6 +236,12 @@ describe('pagination', () => {
         expect(testComponent.pageIndex).toBe(5);
       });
     });
+    it('should be hidden pagination when total is 0 and nzHideOnSinglePage is true', () => {
+      (testComponent as NzTestPaginationComponent).total = 0;
+      (testComponent as NzTestPaginationComponent).hideOnSinglePage = true;
+      fixture.detectChanges();
+      expect(fixture.debugElement.nativeElement.querySelector('.ant-pagination')).toBeNull();
+    });
   });
   describe('pagination render items', () => {
     let fixture;