Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:affix anchor backtop): refactor affix anchor backtop #1025

Merged
merged 14 commits into from
Mar 13, 2018
Merged

feat(module:affix anchor backtop): refactor affix anchor backtop #1025

merged 14 commits into from
Mar 13, 2018

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Feb 6, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

coveralls commented Feb 6, 2018

Coverage Status

Coverage decreased (-0.1%) to 98.076% when pulling bb2e3f5 on cipchk:affix into abb7de0 on NG-ZORRO:0.7.0.

@cipchk cipchk changed the title feat(module:affix): refactor affix feat(module:affix anchor): refactor affix anchor Feb 6, 2018
@cipchk cipchk changed the title feat(module:affix anchor): refactor affix anchor feat(module:affix anchor backtop): refactor affix anchor backtop Feb 7, 2018
@cipchk cipchk changed the title feat(module:affix anchor backtop): refactor affix anchor backtop wip(module:affix anchor backtop): refactor affix anchor backtop Feb 7, 2018
@vthinkxie vthinkxie added this to the 0.7.0 milestone Feb 22, 2018
@cipchk cipchk changed the title wip(module:affix anchor backtop): refactor affix anchor backtop feat(module:affix anchor backtop): refactor affix anchor backtop Feb 28, 2018
@codecov
Copy link

codecov bot commented Mar 13, 2018

Codecov Report

Merging #1025 into 0.7.0 will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            0.7.0    #1025      +/-   ##
==========================================
+ Coverage   97.88%   98.01%   +0.13%     
==========================================
  Files         149      156       +7     
  Lines        5159     5448     +289     
  Branches      620      656      +36     
==========================================
+ Hits         5050     5340     +290     
+ Partials      109      108       -1
Impacted Files Coverage Δ
components/anchor/nz-anchor.component.ts 100% <100%> (ø)
components/back-top/nz-back-top.module.ts 100% <100%> (ø)
components/affix/nz-affix.component.ts 100% <100%> (ø)
components/back-top/nz-back-top.component.ts 100% <100%> (ø)
components/anchor/nz-anchor-link.component.ts 100% <100%> (ø)
components/anchor/nz-anchor.module.ts 100% <100%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9efbaa...e230bf2. Read the comment docs.

@vthinkxie vthinkxie merged commit 24abd10 into NG-ZORRO:0.7.0 Mar 13, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…ZORRO#1025)

* feat(module:affix anchor back-top): refactor affix anchor back-top

* fix lint

* add test & fix lint & Use NzUpdateHostClassService Instead of class operation

* fix tslint & add edge testing

* add edge testing

* fix tslint

* add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants