feat(module:list): add list component #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add third libs with share.module
vthinkxie
reviewed
Feb 7, 2018
|
|
||
| constructor(private http: HttpClient, private msg: NzMessageService) {} | ||
|
|
||
| ngOnInit() { |
vthinkxie
reviewed
Feb 7, 2018
components/list/nz-list.component.ts
Outdated
| @@ -139,8 +137,6 @@ export class NzListComponent implements OnChanges, OnInit { | |||
|
|
|||
| constructor(private _el: ElementRef, private _renderer: Renderer2, private cd: ChangeDetectorRef) {} | |||
There was a problem hiding this comment.
非setter和getter的private不需要加_下划线，统一一下编码规范好了
cipchk
changed the title
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* wip(module:list): add list component - add third libs with share.module * fix lint & clean invalid code * Use NzUpdateHostClassService Instead of class operation * update test status * fix string and template invalid switched * fix tslint * fix nz-card
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information