Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:modal): support triggerOk/triggerCancel to trigger nzOnOk… #1201

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

wilsoncook
Copy link
Member

…/nzOnCancel manually

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Mar 23, 2018

Codecov Report

Merging #1201 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1201      +/-   ##
==========================================
+ Coverage   96.78%   96.78%   +<.01%     
==========================================
  Files         185      185              
  Lines        7653     7657       +4     
  Branches     1001     1001              
==========================================
+ Hits         7407     7411       +4     
  Misses         56       56              
  Partials      190      190
Impacted Files Coverage Δ
components/modal/nz-modal-ref.class.ts 100% <ø> (ø) ⬆️
components/modal/nz-modal.component.ts 96.53% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad80297...76dd030. Read the comment docs.

@wilsoncook wilsoncook merged commit 8cc016e into NG-ZORRO:master Mar 23, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant