Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:table): fix scrollbar calc #1315

Merged
merged 1 commit into from
Apr 12, 2018
Merged

fix(module:table): fix scrollbar calc #1315

merged 1 commit into from
Apr 12, 2018

Conversation

vthinkxie
Copy link
Member

@vthinkxie vthinkxie commented Apr 12, 2018

close #1205

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Apr 12, 2018

Codecov Report

Merging #1315 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1315      +/-   ##
==========================================
+ Coverage   97.34%   97.34%   +<.01%     
==========================================
  Files         191      191              
  Lines        7903     7904       +1     
  Branches     1034     1034              
==========================================
+ Hits         7693     7694       +1     
  Misses         21       21              
  Partials      189      189
Impacted Files Coverage Δ
components/modal/nz-modal.component.ts 96.33% <100%> (+0.01%) ⬆️
components/table/nz-table.component.ts 94.19% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0254838...325c73b. Read the comment docs.

@vthinkxie vthinkxie merged commit 0416900 into NG-ZORRO:master Apr 12, 2018
@vthinkxie vthinkxie deleted the fix-scroll-bar branch October 10, 2018 02:50
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

measureScrollbar() 导致 css3 transition重绘
1 participant