Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: cascader): fix custom render with nzClear #1676

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

simplejason
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@simplejason
Copy link
Member Author

#1646

@codecov
Copy link

codecov bot commented Jun 17, 2018

Codecov Report

Merging #1676 into master will decrease coverage by <.01%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1676      +/-   ##
==========================================
- Coverage   96.01%   96.01%   -0.01%     
==========================================
  Files         466      466              
  Lines       11091    11106      +15     
  Branches     1462     1464       +2     
==========================================
+ Hits        10649    10663      +14     
  Misses        125      125              
- Partials      317      318       +1
Impacted Files Coverage Δ
components/tree/nz-tree.component.ts 100% <100%> (ø) ⬆️
components/cascader/nz-cascader.component.ts 95.98% <100%> (ø) ⬆️
components/tree/nz-tree.service.ts 95.56% <92.3%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a4332a...15d263f. Read the comment docs.

@vthinkxie vthinkxie merged commit c683bc3 into NG-ZORRO:master Jun 22, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@simplejason simplejason deleted the simplejason-fix branch November 23, 2021 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants