Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:*): patch all components with setDisabledState #188

Merged
merged 11 commits into from
Sep 4, 2017
Merged

fix(module:*): patch all components with setDisabledState #188

merged 11 commits into from
Sep 4, 2017

Conversation

create-share
Copy link
Contributor

@create-share create-share commented Aug 29, 2017

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #134 #195

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Patch all components with setDisabledState.
Work in process:

  • input
  • input-number
  • select
  • slider
  • switch
  • rate
  • datepicker
  • timepicker
  • checkbox-group
  • radio-group
  • cascader

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 40.35% when pulling a684952 on deart1mer:master into 29a5cbf on NG-ZORRO:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 40.35% when pulling 0632fe1 on deart1mer:master into 29a5cbf on NG-ZORRO:master.

@create-share create-share changed the title fix(module:input): fix disable bug in reactive form (#134) fix(module:*): patch all components with setDisabledState Aug 29, 2017
@create-share
Copy link
Contributor Author

@vthinkxie
Hi. I'm trying to help to patch all components with setDisabledState, but I found an unnormal behavior in some of the disabled components. I can not make a decision to fix it or not.
I found that the popup(dropdown) of components like select, datepicker, timepicker and so on won't be disabled and closed while they have been opened.
This is not just about setDisabledState, which is related to the disabled behavior of the component itself.
Is this an unnormal behavior? If is, should I fix it when I fix the setDisabledState, or just follow the original behavior and open another issue to fix it?

For example:
Steps:

  1. Open select component's dropdown.
  2. Select component disable by a timer.

Expect:
Select component close dropdown or disable the selection from user.

Current:
Select component become disabled status but dropdown selection still work for user.
image

@vthinkxie
Copy link
Member

vthinkxie commented Aug 30, 2017

@deart1mer
The dropdown should be closed when the component disabled.
Please open another issue and fix it if you wish.
Thanks for your pr and feedback.

@create-share
Copy link
Contributor Author

@vthinkxie Yeah. I would like to do that.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 40.35% when pulling f268686 on deart1mer:master into 29a5cbf on NG-ZORRO:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0008%) to 40.347% when pulling f268686 on deart1mer:master into 29a5cbf on NG-ZORRO:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 40.35% when pulling e8cd9c5 on deart1mer:master into 29a5cbf on NG-ZORRO:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 40.327% when pulling ebbc8ad on deart1mer:master into 29a5cbf on NG-ZORRO:master.

@create-share
Copy link
Contributor Author

@vthinkxie Hi, I have patched all components with setDisabledState. Should I fix #190 in a new pr?

@vthinkxie
Copy link
Member

@deart1mer yes, we will merge this after review, thanks for your effort.

@vthinkxie vthinkxie merged commit 69b8979 into NG-ZORRO:master Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants