feat(module:radio): add solid button style #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1892 +/- ##
==========================================
+ Coverage 95.95% 95.97% +0.01%
==========================================
Files 468 468
Lines 11242 11245 +3
Branches 1474 1474
==========================================
+ Hits 10787 10792 +5
+ Misses 131 130 -1
+ Partials 324 323 -1
Continue to review full report at Codecov.
|
hsuanxyz
approved these changes
Jul 28, 2018
vthinkxie
reviewed
Aug 3, 2018
components/radio/doc/index.en-US.md
Outdated
| @@ -34,6 +34,7 @@ radio group，wrap a group of `nz-radio`。 | |||
| | `[nzDisabled]` | Disable all radio buttons | boolean | false | | |||
| | `[nzSize]` | Size, only on radio style | `large` `default` `small` | `default` | | |||
| | `(ngModelChange)` | the callback function when current selected `nz-radio` value change | `EventEmitter<string>` | - | | |||
| | `[nzButtonStyle]` | style type of radio button | `outline` \| `solid` | `outline` | | |||
vthinkxie
reviewed
Aug 3, 2018
components/radio/doc/index.zh-CN.md
Outdated
| @@ -36,6 +36,7 @@ title: Radio | |||
| | `[nzDisabled]` | 设定所有 `nz-radio` disable 状态 | boolean | false | | |||
| | `[nzSize]` | 大小，只对按钮样式生效 | `large` ｜ `default` ｜ `small` | `default` | | |||
| | `(ngModelChange)` | 选中变化时回调 | `EventEmitter<boolean>` | - | | |||
| | `[nzButtonStyle]` | RadioButton 的风格样式，目前有描边和填色两种风格 | `outline` \| `solid` | `outline` | | |||
vthinkxie
requested changes
Aug 3, 2018
close NG-ZORRO#1891 remove redundant property
vthinkxie
approved these changes
Aug 3, 2018
wenqi73
pushed a commit
to wenqi73/ng-zorro-antd
that referenced
this pull request
Aug 27, 2018
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1891
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1891
What is the new behavior?
Same as https://ant.design/components/radio/#components-radio-demo-radiobutton-solid.
Does this PR introduce a breaking change?
Other information
I temporarily add style in
index.less.