Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select, datepicker, timepicker, radio, checkbox, input-number) fix touched state #248

Merged
merged 1 commit into from
Sep 9, 2017

Conversation

create-share
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
#228

What is the new behavior?

Fix these module:

  • select
  • datepicker
  • timepicker
  • radio
  • checkbox
  • input-number

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 40.985% when pulling 5938960 on deart1mer:fix-touched-state into 2f031ce on NG-ZORRO:master.

@vthinkxie
Copy link
Member

please keep the commit history clean, thanks.

@vthinkxie
Copy link
Member

please remove the commit log of Merge branch 'master' into fix-touched-state
you can use squash option to remove it.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 40.645% when pulling 34fe4c7 on deart1mer:fix-touched-state into d8063a1 on NG-ZORRO:master.

@create-share
Copy link
Contributor Author

Sorry for that, it took me some time to figure it out how to do that. Now is it all right?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 40.712% when pulling 7987da5 on deart1mer:fix-touched-state into 4233db1 on NG-ZORRO:master.

@vthinkxie
Copy link
Member

Yes

@vthinkxie vthinkxie merged commit 07f48bc into NG-ZORRO:master Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants