Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:checkbox): fix trigger twitce in safari #256

Merged
merged 1 commit into from
Sep 9, 2017

Conversation

SangKa
Copy link
Contributor

@SangKa SangKa commented Sep 9, 2017

Close #254

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #254

What is the new behavior?

make nzChecked @input only and only let the click on the host to control the check status.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 40.999% when pulling 47c0fd2 on SangKa:fix-254 into 2f031ce on NG-ZORRO:master.

@vthinkxie vthinkxie merged commit cd5b511 into NG-ZORRO:master Sep 9, 2017
@SangKa SangKa deleted the fix-254 branch September 9, 2017 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nzCheckbox and Checkbox Can not be used in safari 10.1.2
3 participants