Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:upload): support Observable in nzFilter #2590

Merged
merged 3 commits into from Dec 11, 2018
Merged

feat(module:upload): support Observable in nzFilter #2590

merged 3 commits into from Dec 11, 2018

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Dec 5, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number:

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #2590 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2590      +/-   ##
==========================================
+ Coverage    95.5%   95.64%   +0.14%     
==========================================
  Files         495      495              
  Lines       12098    12059      -39     
  Branches     1689     1681       -8     
==========================================
- Hits        11554    11534      -20     
+ Misses        172      167       -5     
+ Partials      372      358      -14
Impacted Files Coverage Δ
components/list/nz-list.component.ts 100% <ø> (ø) ⬆️
components/upload/nz-upload-btn.component.ts 98.19% <100%> (+0.07%) ⬆️
...mponents/input-number/nz-input-number.component.ts 98.98% <0%> (-0.02%) ⬇️
components/input/nz-input-group.component.ts 100% <0%> (ø) ⬆️
components/collapse/nz-collapse-panel.component.ts 100% <0%> (ø) ⬆️
components/input/nz-input.module.ts 100% <0%> (ø) ⬆️
components/core/util/public-api.ts 100% <0%> (ø) ⬆️
components/core/util/calculate-node-height.ts
components/input/nz-autoresize.directive.ts 90.24% <0%> (ø)
components/table/nz-table.component.ts 96.66% <0%> (+1.11%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef10595...9368ff6. Read the comment docs.

@netlify
Copy link

netlify bot commented Dec 5, 2018

Deploy preview for ng-zorro-master ready!

Built with commit 9368ff6

https://deploy-preview-2590--ng-zorro-master.netlify.com

@hsuanxyz hsuanxyz merged commit c664c6f into NG-ZORRO:master Dec 11, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:upload): support Observable in nzFilter

* chore: fix test

* fix(module:list): fix missing :host

close NG-ZORRO#2389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants