Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:mention): fix cannot to switch trigger #3632

Merged
merged 3 commits into from
Jun 26, 2019

Conversation

hsuanxyz
Copy link
Member

close #3629

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@netlify
Copy link

netlify bot commented Jun 24, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 4fbc147

https://deploy-preview-3632--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jun 24, 2019

Codecov Report

Merging #3632 into master will decrease coverage by <.01%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3632      +/-   ##
==========================================
- Coverage   95.46%   95.46%   -0.01%     
==========================================
  Files         685      687       +2     
  Lines       14080    14112      +32     
  Branches     1874     1879       +5     
==========================================
+ Hits        13442    13472      +30     
- Misses        226      227       +1     
- Partials      412      413       +1
Impacted Files Coverage Δ
components/mention/nz-mention-trigger.ts 100% <100%> (ø) ⬆️
components/mention/public-api.ts 100% <100%> (ø) ⬆️
components/mention/nz-mention.component.ts 98.85% <91.66%> (-0.57%) ⬇️
components/mention/nz-mention.service.ts 92.3% <92.3%> (ø)
components/dropdown/nz-dropdown.directive.ts 88.95% <0%> (-2.24%) ⬇️
components/table/nz-table.component.ts 93.54% <0%> (-0.69%) ⬇️
components/grid/demo/responsive.ts 100% <0%> (ø) ⬆️
components/grid/demo/offset.ts 100% <0%> (ø) ⬆️
components/grid/demo/flex-order.ts 100% <0%> (ø) ⬆️
components/comment/demo/nested.ts 100% <0%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8db4f9b...4fbc147. Read the comment docs.

@vthinkxie vthinkxie self-requested a review June 25, 2019 10:46
@vthinkxie vthinkxie self-assigned this Jun 25, 2019
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit c8b5b09 into NG-ZORRO:master Jun 26, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* fix(module:mention): fix cannot to switch trigger

close NG-ZORRO#3629

* test(module:mention): add test

* docs(module:mention): fix API
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* fix(module:mention): fix cannot to switch trigger

close NG-ZORRO#3629

* test(module:mention): add test

* docs(module:mention): fix API
@hsuanxyz hsuanxyz deleted the fix/mention branch August 5, 2020 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[next] mention: Cannot read property 'onInput' of undefined
3 participants