Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:pagination): fix pagination nzTotal 0 bug #3651

Merged
merged 1 commit into from
Jun 25, 2019
Merged

fix(module:pagination): fix pagination nzTotal 0 bug #3651

merged 1 commit into from
Jun 25, 2019

Conversation

vthinkxie
Copy link
Member

close #3648

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jun 25, 2019

Deploy preview for ng-zorro-master ready!

Built with commit d125478

https://deploy-preview-3651--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #3651 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3651      +/-   ##
==========================================
- Coverage   95.43%   95.42%   -0.01%     
==========================================
  Files         686      686              
  Lines       14091    14091              
  Branches     1877     1877              
==========================================
- Hits        13448    13447       -1     
  Misses        229      229              
- Partials      414      415       +1
Impacted Files Coverage Δ
components/pagination/nz-pagination.component.ts 98.95% <100%> (ø) ⬆️
components/time-picker/time-holder.ts 96.57% <0%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecae334...b85537c. Read the comment docs.

@netlify
Copy link

netlify bot commented Jun 25, 2019

Deploy preview for ng-zorro-master ready!

Built with commit b85537c

https://deploy-preview-3651--ng-zorro-master.netlify.com

@vthinkxie vthinkxie merged commit d28fc49 into NG-ZORRO:master Jun 25, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pagination next not disable when nzTotal equals 0
1 participant