Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:*): import PlatformModule when use platform in component #3823

Merged

Conversation

NearZXH
Copy link
Contributor

@NearZXH NearZXH commented Jul 19, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

import PlatformModule when use platform in component

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@vthinkxie According to pull request (#3709) discussion, i check all the module.

@netlify
Copy link

netlify bot commented Jul 19, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 2ba6106

https://deploy-preview-3823--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #3823 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3823      +/-   ##
==========================================
+ Coverage   95.36%   95.37%   +<.01%     
==========================================
  Files         723      723              
  Lines       14722    14737      +15     
  Branches     1937     1937              
==========================================
+ Hits        14040    14055      +15     
  Misses        249      249              
  Partials      433      433
Impacted Files Coverage Δ
components/carousel/nz-carousel.module.ts 100% <100%> (ø) ⬆️
components/statistic/nz-statistic.module.ts 100% <100%> (ø) ⬆️
components/back-top/nz-back-top.module.ts 100% <100%> (ø) ⬆️
components/slider/nz-slider.module.ts 100% <100%> (ø) ⬆️
components/typography/nz-typography.module.ts 100% <100%> (ø) ⬆️
components/affix/nz-affix.module.ts 100% <100%> (ø) ⬆️
components/select/nz-select.module.ts 100% <100%> (ø) ⬆️
components/anchor/nz-anchor.module.ts 100% <100%> (ø) ⬆️
components/upload/nz-upload.module.ts 100% <100%> (ø) ⬆️
components/avatar/nz-avatar.module.ts 100% <100%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f022a0f...2ba6106. Read the comment docs.

@wzhudev wzhudev requested a review from hsuanxyz July 23, 2019 06:55
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit 6ec85a4 into NG-ZORRO:master Jul 26, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants