Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tooltip): empty judgement #3993

Merged
merged 3 commits into from
Aug 13, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Aug 13, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@netlify
Copy link

netlify bot commented Aug 13, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 3617778

https://deploy-preview-3993--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #3993 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3993     +/-   ##
=========================================
- Coverage   93.25%   93.15%   -0.1%     
=========================================
  Files         500      500             
  Lines       10615    10614      -1     
  Branches     1924     1924             
=========================================
- Hits         9899     9888     -11     
- Misses        301      310      +9     
- Partials      415      416      +1
Impacted Files Coverage Δ
...s/tooltip/base/nz-tooltip-base-legacy.component.ts 96.15% <ø> (-0.15%) ⬇️
...mponents/tooltip/base/nz-tooltip-base.component.ts 94.44% <100%> (+2.77%) ⬆️
components/popover/nz-popover.component.ts 100% <100%> (ø) ⬆️
components/tabs/nz-tabs-ink-bar.directive.ts 60% <0%> (-30%) ⬇️
components/rate/nz-rate.component.ts 93.1% <0%> (-4.6%) ⬇️
components/time-picker/time-holder.ts 96.49% <0%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d27fb6...3617778. Read the comment docs.

@wzhudev wzhudev merged commit a853e96 into NG-ZORRO:master Aug 13, 2019
@wzhudev wzhudev deleted the fix-tooltip-empty branch August 14, 2019 01:42
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* fix: empty judgement

* fix: remove useless property

* fix(module:popover): fix propertyName

patch NG-ZORRO#3909
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* fix: empty judgement

* fix: remove useless property

* fix(module:popover): fix propertyName

patch NG-ZORRO#3909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants