Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:cascader): support falsy value expect for undefined and null #4119

Merged
merged 2 commits into from
Sep 6, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Sep 5, 2019

close #4110

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4110

What is the new behavior?

Value could be falsy value expect for undefined and null.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Sep 5, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 4ccfc53

https://deploy-preview-4119--ng-zorro-master.netlify.com

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test case?

@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #4119 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4119   +/-   ##
=======================================
  Coverage   92.32%   92.32%           
=======================================
  Files         506      506           
  Lines       10761    10761           
  Branches     1952     1952           
=======================================
  Hits         9935     9935           
  Misses        407      407           
  Partials      419      419
Impacted Files Coverage Δ
components/cascader/nz-cascader.service.ts 96.7% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7c7f8f...4ccfc53. Read the comment docs.

@wzhudev
Copy link
Member Author

wzhudev commented Sep 5, 2019

Add a test case?

Will be covered in spec should write value work.

@hsuanxyz hsuanxyz merged commit 0cb44ac into NG-ZORRO:master Sep 6, 2019
@wzhudev wzhudev deleted the cascader-falsy-value branch September 20, 2019 02:22
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…ll (NG-ZORRO#4119)

* fix(module:cascader): support falsy value expect for undefined and null

* fix: tests

close NG-ZORRO#4110
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…ll (NG-ZORRO#4119)

* fix(module:cascader): support falsy value expect for undefined and null

* fix: tests

close NG-ZORRO#4110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cascader value为0问题
3 participants