Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:drawer): content overflow when placement is top or bottom #4423

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

hsuanxyz
Copy link
Member

close #4354

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4354

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Nov 12, 2019

Deploy preview for ng-zorro-master ready!

Built with commit d4ca8dd

https://deploy-preview-4423--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #4423 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4423      +/-   ##
==========================================
+ Coverage   92.23%   92.24%   +<.01%     
==========================================
  Files         522      522              
  Lines       11104    11104              
  Branches     2016     2016              
==========================================
+ Hits        10242    10243       +1     
  Misses        435      435              
+ Partials      427      426       -1
Impacted Files Coverage Δ
components/time-picker/time-holder.ts 96.49% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 367dc6c...d4ca8dd. Read the comment docs.

@simplejason
Copy link
Member

please check this, the drawer is flashing when I change nzPlacement with ngModel.
Is it a bug of drawer?

drawer-error

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check my comment

@qq232650413
Copy link

火狐浏览器 依然 溢出被遮挡

Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz hsuanxyz deleted the fix/drawer-overflow branch August 5, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NzDrawerService创建的组件设置nzPlacement 为top时,超出的内容无法滚动
4 participants