feat(module:notification): add close icon prop #4495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the checks is complete. |
hsuanxyz
reviewed
Dec 2, 2019
| <i nz-icon nzType="close" class="ant-notification-close-icon"></i> | ||
| <ng-container *ngIf="nzMessage.options?.nzCloseIcon"> | ||
| <ng-container *nzStringTemplateOutlet="nzMessage.options?.nzCloseIcon"> | ||
| <i nz-icon [nzType]="nzMessage.options?.nzCloseIcon"></i> |
|
Deploy preview for ng-zorro-master ready! Built with commit a7a8886 |
Codecov Report
@@ Coverage Diff @@
## master #4495 +/- ##
=======================================
Coverage 92.01% 92.01%
=======================================
Files 519 519
Lines 10925 10925
Branches 1983 1983
=======================================
Hits 10053 10053
Misses 448 448
Partials 424 424
Continue to review full report at Codecov.
|
vthinkxie
reviewed
Dec 2, 2019
| <i nz-icon [nzType]="nzMessage.options?.nzCloseIcon"></i> | ||
| </ng-container> | ||
| </ng-container> | ||
| <ng-container *ngIf="!nzMessage.options?.nzCloseIcon"> |
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
* feat(module:notification): add close icon prop close NG-ZORRO#4494 * fix: use else instead
Closed
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* feat(module:notification): add close icon prop close NG-ZORRO#4494 * fix: use else instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4494
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #4494
What is the new behavior?
Does this PR introduce a breaking change?
Other information