Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:table): fix table no data #4947

Merged
merged 1 commit into from Mar 30, 2020

Conversation

vthinkxie
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #4947 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4947   +/-   ##
=======================================
  Coverage   91.55%   91.55%           
=======================================
  Files         535      535           
  Lines       13686    13688    +2     
  Branches     2043     2043           
=======================================
+ Hits        12530    12532    +2     
  Misses        693      693           
  Partials      463      463           
Impacted Files Coverage Δ
components/table/src/table-data.service.ts 89.09% <100.00%> (ø)
components/table/src/table/table.component.ts 88.80% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ecdb9...22fcf7e. Read the comment docs.

@vthinkxie vthinkxie force-pushed the fix-table-no-data branch 4 times, most recently from de8a96f to 6bba180 Compare March 30, 2020 04:29
@vthinkxie vthinkxie merged commit 7f7989e into NG-ZORRO:master Mar 30, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants