Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:notification): fix global config nzPlacement not working #5140

Merged
merged 2 commits into from Apr 26, 2020

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Apr 24, 2020

close #5135

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 24, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #5140 into master will decrease coverage by 0.05%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5140      +/-   ##
==========================================
- Coverage   91.46%   91.41%   -0.06%     
==========================================
  Files         547      547              
  Lines       13747    13763      +16     
  Branches     2130     2135       +5     
==========================================
+ Hits        12574    12581       +7     
- Misses        708      713       +5     
- Partials      465      469       +4     
Impacted Files Coverage Δ
...s/notification/notification-container.component.ts 94.23% <70.00%> (-5.77%) ⬇️
components/table/src/table/tbody.component.ts 85.71% <0.00%> (-14.29%) ⬇️
components/table/src/table/tr-measure.component.ts 86.95% <0.00%> (-13.05%) ⬇️
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/time-picker/time-holder.ts 94.73% <0.00%> (-1.06%) ⬇️
components/select/select.module.ts 100.00% <0.00%> (ø)
components/select/select.component.ts 90.60% <0.00%> (ø)
components/date-picker/date-picker.component.ts 96.47% <0.00%> (+0.07%) ⬆️
components/select/option-container.component.ts 91.66% <0.00%> (+0.75%) ⬆️
components/select/select-search.component.ts 87.50% <0.00%> (+1.13%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eca795...348f173. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vthinkxie vthinkxie merged commit 1ce1634 into NG-ZORRO:master Apr 26, 2020
@wzhudev wzhudev deleted the notification-config branch April 26, 2020 09:04
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…G-ZORRO#5140)

* fix(module:notification): fix global config nzPlacement not working

close NG-ZORRO#5135

* fix: fix tslint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications global configuration doesn't work
3 participants