Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:dropdown): fix dropdown break SSR #5244

Merged
merged 1 commit into from May 11, 2020

Conversation

vthinkxie
Copy link
Member

close #5186

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented May 10, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #5244 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5244   +/-   ##
=======================================
  Coverage   91.44%   91.44%           
=======================================
  Files         548      548           
  Lines       13859    13864    +5     
  Branches     2091     2091           
=======================================
+ Hits        12673    12678    +5     
  Misses        705      705           
  Partials      481      481           
Impacted Files Coverage Δ
components/dropdown/dropdown.module.ts 100.00% <ø> (ø)
components/dropdown/dropdown.directive.ts 88.17% <100.00%> (+0.67%) ⬆️
components/timeline/timeline-item.component.ts 100.00% <100.00%> (ø)
components/timeline/timeline.component.ts 97.67% <100.00%> (ø)
components/timeline/timeline.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee2859f...e462f02. Read the comment docs.

@vthinkxie vthinkxie merged commit 016cca1 into NG-ZORRO:master May 11, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-dropdown breaks SSR (Angular universal)
2 participants