Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:progress): fix value not updated when is steps #5676

Merged
merged 2 commits into from Sep 22, 2020

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Aug 14, 2020

close #5585

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #5676 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5676   +/-   ##
=======================================
  Coverage   90.27%   90.28%           
=======================================
  Files         456      456           
  Lines       13747    13747           
  Branches     2164     2165    +1     
=======================================
+ Hits        12410    12411    +1     
+ Misses        821      818    -3     
- Partials      516      518    +2     
Impacted Files Coverage Δ
components/progress/progress.component.ts 95.23% <100.00%> (+0.11%) ⬆️
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
components/tabs/tab-nav-bar.component.ts 80.91% <0.00%> (-1.42%) ⬇️
components/date-picker/date-picker.component.ts 94.81% <0.00%> (-0.78%) ⬇️
...mponents/date-picker/date-range-popup.component.ts 91.07% <0.00%> (+1.07%) ⬆️
components/table/src/table/tr-measure.component.ts 100.00% <0.00%> (+13.63%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b909354...6cbf563. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 3eecc44 into NG-ZORRO:master Sep 22, 2020
@github-actions
Copy link

github-actions bot commented Sep 22, 2020

😭 Deploy PR Preview 3eecc44 failed. Build logs

🤖 By surge-preview

@wzhudev wzhudev deleted the fix/progress-bar branch September 23, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress bar with step not working dynamically
2 participants