Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): modify date-fns week-year format #5753

Merged
merged 1 commit into from Sep 10, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Sep 8, 2020

Fixes #5327

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #5753 into master will decrease coverage by 0.02%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5753      +/-   ##
==========================================
- Coverage   90.06%   90.04%   -0.03%     
==========================================
  Files         455      455              
  Lines       13836    13846      +10     
  Branches     2262     2267       +5     
==========================================
+ Hits        12462    12468       +6     
- Misses        848      851       +3     
- Partials      526      527       +1     
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 95.58% <0.00%> (-0.74%) ⬇️
components/date-picker/date-picker.service.ts 100.00% <100.00%> (ø)
...mponents/date-picker/date-range-popup.component.ts 90.00% <100.00%> (+0.11%) ⬆️
components/date-picker/picker.component.ts 95.94% <100.00%> (ø)
components/tabs/tab-nav-operation.component.ts 59.37% <0.00%> (-2.70%) ⬇️
components/i18n/date-helper.service.ts 85.00% <0.00%> (-2.50%) ⬇️
components/tabs/tabset.component.ts 86.20% <0.00%> (-0.93%) ⬇️
components/tabs/tab-link.directive.ts 37.50% <0.00%> (ø)
components/mention/mention.component.ts 98.79% <0.00%> (ø)
components/tabs/tab.component.ts 92.85% <0.00%> (+0.26%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32e3066...dbbb1f5. Read the comment docs.

@wenqi73 wenqi73 force-pushed the fix-week-number branch 5 times, most recently from adbdb88 to 748b5d3 Compare September 9, 2020 13:16
@hsuanxyz hsuanxyz merged commit 4911e36 into NG-ZORRO:master Sep 10, 2020
@github-actions
Copy link

github-actions bot commented Sep 10, 2020

😭 Deploy PR Preview 4911e36 failed. Build logs

🤖 By surge-preview

@wenqi73 wenqi73 deleted the fix-week-number branch September 10, 2020 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-week-picker使用darte-fns初始化之后每年的第一周显示错误bug
2 participants