Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:tree-select): support virtual scroll #5760

Merged
merged 1 commit into from Sep 14, 2020

Conversation

hsuanxyz
Copy link
Member

close #5589

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5589

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #5760 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5760      +/-   ##
==========================================
- Coverage   90.04%   90.04%   -0.01%     
==========================================
  Files         455      455              
  Lines       13843    13851       +8     
  Branches     2264     2266       +2     
==========================================
+ Hits        12465    12472       +7     
  Misses        852      852              
- Partials      526      527       +1     
Impacted Files Coverage Δ
components/tree-select/tree-select.component.ts 94.38% <100.00%> (+0.11%) ⬆️
components/i18n/date-helper.service.ts 85.00% <0.00%> (-2.50%) ⬇️
components/date-picker/date-picker.component.ts 95.58% <0.00%> (-0.74%) ⬇️
components/date-picker/testing/util.ts 100.00% <0.00%> (ø)
components/skeleton/skeleton.module.ts 100.00% <0.00%> (ø)
components/skeleton/skeleton.component.ts 100.00% <0.00%> (ø)
components/date-picker/date-picker.service.ts 100.00% <0.00%> (ø)
...mponents/date-picker/date-range-popup.component.ts 90.00% <0.00%> (+0.11%) ⬆️
components/skeleton/skeleton-element.component.ts 94.11% <0.00%> (+0.36%) ⬆️
components/date-picker/picker.component.ts 96.57% <0.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc14ba...f69224a. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 1f2d816 into NG-ZORRO:master Sep 14, 2020
@hsuanxyz hsuanxyz deleted the feat/tree-select-virtual-scroll branch September 14, 2020 01:38
@github-actions
Copy link

github-actions bot commented Sep 14, 2020

😭 Deploy PR Preview 1f2d816 failed. Build logs

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

treeselect 添加虚拟列表的模式
1 participant