Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:pagination): fix shoule be only allowed number #5895

Merged
merged 1 commit into from Oct 11, 2020
Merged

fix(module:pagination): fix shoule be only allowed number #5895

merged 1 commit into from Oct 11, 2020

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Oct 10, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Oct 10, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #5895 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5895   +/-   ##
=======================================
  Coverage   90.02%   90.02%           
=======================================
  Files         463      463           
  Lines       13941    13941           
  Branches     2204     2204           
=======================================
  Hits        12551    12551           
  Misses        855      855           
  Partials      535      535           
Impacted Files Coverage Δ
...ponents/pagination/pagination-options.component.ts 92.59% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38f3ece...392d267. Read the comment docs.

@vthinkxie vthinkxie merged commit 69a1205 into NG-ZORRO:master Oct 11, 2020
@github-actions
Copy link

github-actions bot commented Oct 11, 2020

😭 Deploy PR Preview 69a1205 failed. Build logs

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nzShowQuickJumper
2 participants