fix(module:select): accept 0 value on enter

[vazgen6]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

When using nz-select component with an option where [nzValue]="0" and hitting enter the value is not being saved, because this.activatedValue = 0 and it is a falsy value thus not entering the if block to call the onItemClick method.

Issue Number: N/A

What is the new behavior?

Optional @input() was added to solve this problem. By passing [nzAcceptZeroValue]="true" to NzSelectComponent

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

I don't know Chinese the Chinese docs were Google translated.

[zorro-bot]

This preview will be available after the AzureCI is passed.

[codecov]

Codecov Report

Merging #5904 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5904      +/-   ##
==========================================
- Coverage   90.02%   90.01%   -0.02%     
==========================================
  Files         463      463              
  Lines       13946    13946              
  Branches     2201     2201              
==========================================
- Hits        12555    12553       -2     
- Misses        857      859       +2     
  Partials      534      534              

Impacted Files	Coverage Δ
components/select/select.component.ts	87.67% <0.00%> (ø)
components/tabs/tab-nav-bar.component.ts	80.91% <0.00%> (-1.42%)	⬇️
components/core/util/text-measure.ts	91.30% <0.00%> (+1.73%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b5fdee...6a3213c. Read the comment docs.

[hsuanxyz]

@vthinkxie I think it's a bug, if 0 is valid value, it should also be handled correctly by the keyboard.

[hsuanxyz]

@vazgen6 Thanks for the PR, no need to a new input here, just correct judgement!

+ import { isNotNil } from 'ng-zorro-antd/core/util';

- if (this.activatedValue)
+ if (isNotNil(this.activatedValue))

[vthinkxie]

Hi @vazgen6
thanks for your PR, I agree with @hsuanxyz
could you update your PR following @hsuanxyz 's suggestion?

[vazgen6]

@vazgen6 Thanks for the PR, no need to a new input here, just correct judgement!

+ import { isNotNil } from 'ng-zorro-antd/core/util';

- if (this.activatedValue)
+ if (isNotNil(this.activatedValue))

I also agree with this, initially I thought doing something similar but was afraid to break existing behavior but since user can click on it they should be able to use enter to select too.

[vazgen6]

could you update your PR following @hsuanxyz 's suggestion?

Sure thing, I will update it asap.

[vazgen6]

@vthinkxie I think it's a bug, if 0 is valid value, it should also be handled correctly by the keyboard.

@hsuanxyz If this is a bug, should I update my commit message? Or let me know what is more accepted, if I amend with new message and force push will it cause any problems for you?

[hsuanxyz]

@vthinkxie I think it's a bug, if 0 is valid value, it should also be handled correctly by the keyboard.

@hsuanxyz If this is a bug, should I update my commit message? Or let me know what is more accepted, if I amend with new message and force push will it cause any problems for you?

no problem, you can --amend and --force .

[vazgen6]

@vthinkxie I think it's a bug, if 0 is valid value, it should also be handled correctly by the keyboard.

@hsuanxyz If this is a bug, should I update my commit message? Or let me know what is more accepted, if I amend with new message and force push will it cause any problems for you?

no problem, you can --amend and --force .

Done! I just fetched from upstream and rebased. Please let me know if there's something else I can do and thank you for your quick reply and support.

[hsuanxyz]

👏 That's right. We'll merge it when @vthinkxie is done reviewing.

[vthinkxie]

LGTM, good job

[github-actions]

😭 Deploy PR Preview 574fdf0 failed. Build logs

_{🤖 By surge-preview}