Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): display error in dynamic switching nzMode #6125

Merged
merged 1 commit into from Dec 1, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Dec 1, 2020

close #6052

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Dec 1, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #6125 (c600ef0) into master (2f8edbc) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6125      +/-   ##
==========================================
+ Coverage   89.83%   89.85%   +0.01%     
==========================================
  Files         467      467              
  Lines       14213    14218       +5     
  Branches     2234     2235       +1     
==========================================
+ Hits        12768    12775       +7     
+ Misses        894      891       -3     
- Partials      551      552       +1     
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 92.56% <100.00%> (+0.20%) ⬆️
components/date-picker/picker.component.ts 89.54% <100.00%> (+0.06%) ⬆️
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/table/src/table-data.service.ts 84.61% <0.00%> (+6.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f8edbc...c600ef0. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 220a590 into NG-ZORRO:master Dec 1, 2020
@wenqi73 wenqi73 deleted the dp-nzmode branch December 1, 2020 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors received in Datepicker dynamic nzMode selections.
2 participants