Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:table): showPagination in ngIf when nzHideOnSinglePage #6133

Merged
merged 1 commit into from Dec 5, 2020

Conversation

yangjunhan
Copy link
Contributor

close #6080

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #6080

What is the new behavior?

No remaining pagination style including vertical margin is shown after nzHideOnSinglePage.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Dec 2, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #6133 (f0c2404) into master (7ef2ed0) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6133      +/-   ##
==========================================
- Coverage   89.86%   89.81%   -0.05%     
==========================================
  Files         467      468       +1     
  Lines       14214    14248      +34     
  Branches     2238     2240       +2     
==========================================
+ Hits        12773    12797      +24     
- Misses        890      896       +6     
- Partials      551      555       +4     
Impacted Files Coverage Δ
components/table/src/table/table.component.ts 89.72% <100.00%> (+0.36%) ⬆️
components/table/src/table-data.service.ts 78.46% <0.00%> (-6.16%) ⬇️
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/input/input.module.ts 100.00% <0.00%> (ø)
components/tree/tree-indent.component.ts 100.00% <0.00%> (ø)
components/date-picker/lib/abstract-table.ts 89.58% <0.00%> (ø)
components/input/textarea-count.component.ts 84.00% <0.00%> (ø)
components/date-picker/picker.component.ts 89.54% <0.00%> (+0.06%) ⬆️
components/tree/tree-node.component.ts 91.07% <0.00%> (+0.10%) ⬆️
components/date-picker/date-picker.component.ts 92.56% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef2ed0...f0c2404. Read the comment docs.

@hsuanxyz hsuanxyz merged commit fbe13c2 into NG-ZORRO:master Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-table配置nzHideOnSinglePage后, 只有一页时nz-pagination仍然占据高度
2 participants