New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:image): add image component #6154
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #6154 +/- ##
==========================================
- Coverage 89.82% 89.81% -0.01%
==========================================
Files 469 477 +8
Lines 14948 15204 +256
Branches 2273 2302 +29
==========================================
+ Hits 13427 13656 +229
- Misses 935 951 +16
- Partials 586 597 +11
Continue to review full report at Codecov.
|
c1c76cb
to
37d0b92
Compare
@hsuanxyz cc, thanks~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
37d0b92
to
4ccbcd3
Compare
@hsuanxyz Please review again, thanks~ |
437cab6
to
45a87ce
Compare
@stygian-desolator The fit-content action is only applied when the visible area is not completely covered. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
add image component
Does this PR introduce a breaking change?
Other information