Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:image): add image component #6154

Merged
merged 1 commit into from Dec 15, 2020

Conversation

stygian-desolator
Copy link
Collaborator

@stygian-desolator stygian-desolator commented Dec 6, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

add image component

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Dec 6, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 6, 2020

Codecov Report

Merging #6154 (8fb64a0) into master (860dfed) will decrease coverage by 0.00%.
The diff coverage is 91.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6154      +/-   ##
==========================================
- Coverage   89.82%   89.81%   -0.01%     
==========================================
  Files         469      477       +8     
  Lines       14948    15204     +256     
  Branches     2273     2302      +29     
==========================================
+ Hits        13427    13656     +229     
- Misses        935      951      +16     
- Partials      586      597      +11     
Impacted Files Coverage Δ
components/core/config/config.ts 100.00% <ø> (ø)
components/icon/icons.ts 100.00% <ø> (ø)
components/image/image-preview.component.ts 87.85% <87.85%> (ø)
components/image/image.directive.ts 94.44% <94.44%> (ø)
components/image/image.service.ts 95.45% <95.45%> (ø)
components/image/image-config.ts 100.00% <100.00%> (ø)
components/image/image-group.component.ts 100.00% <100.00%> (ø)
components/image/image-preview-options.ts 100.00% <100.00%> (ø)
components/image/image-preview-ref.ts 100.00% <100.00%> (ø)
components/image/image.module.ts 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 860dfed...8fb64a0. Read the comment docs.

@hsuanxyz hsuanxyz marked this pull request as draft December 7, 2020 00:43
@hsuanxyz hsuanxyz self-requested a review December 7, 2020 00:43
@stygian-desolator stygian-desolator marked this pull request as ready for review December 12, 2020 10:23
@stygian-desolator
Copy link
Collaborator Author

@hsuanxyz cc, thanks~

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

components/image/image-preview.component.ts Show resolved Hide resolved
components/image/doc/index.en-US.md Outdated Show resolved Hide resolved
components/image/doc/index.zh-CN.md Outdated Show resolved Hide resolved
@stygian-desolator
Copy link
Collaborator Author

@hsuanxyz Please review again, thanks~

@hsuanxyz
Copy link
Member

@stygian-desolator The fit-content action is only applied when the visible area is not completely covered.

image

@hsuanxyz hsuanxyz merged commit 83dfdf9 into NG-ZORRO:master Dec 15, 2020
@pr-triage pr-triage bot added the PR: merged label Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants