Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:table): add support for ReadonlyArray #6156

Merged
merged 1 commit into from Jan 22, 2021

Conversation

xiaoxiangmoe
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Support ReadonlyArray in nzData

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Some type should rewrite to ReadonlyArray

Other information

@zorro-bot
Copy link

zorro-bot bot commented Dec 7, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #6156 (6931977) into master (13f2281) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6156      +/-   ##
==========================================
- Coverage   89.81%   89.78%   -0.03%     
==========================================
  Files         468      468              
  Lines       14258    14258              
  Branches     2243     2243              
==========================================
- Hits        12806    12802       -4     
- Misses        896      899       +3     
- Partials      556      557       +1     
Impacted Files Coverage Δ
components/table/src/table-data.service.ts 78.46% <100.00%> (ø)
components/table/src/table-style.service.ts 96.55% <100.00%> (ø)
components/table/src/table/table.component.ts 89.72% <100.00%> (ø)
components/table/src/table/tbody.component.ts 85.71% <100.00%> (ø)
components/tabs/tab-nav-bar.component.ts 80.91% <0.00%> (-1.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13f2281...6931977. Read the comment docs.

@vthinkxie vthinkxie merged commit 9d67d0b into NG-ZORRO:master Jan 22, 2021
ZhWent pushed a commit to ZhWent/ng-zorro-antd that referenced this pull request Mar 3, 2021
* upsteam/master:
  fix(schematics): fix `add-icon-assets`  schema path (NG-ZORRO#6404)
  fix(module:tree-view): correct API typo (NG-ZORRO#6386)
  chore(release): release 11.1.0 (NG-ZORRO#6371)
  fix(module:table): fix table `nzBordered` (NG-ZORRO#6367)
  fix(module:typography): edit area cannot get the content (NG-ZORRO#6369)
  feat(module:table): add support for ReadonlyArray (NG-ZORRO#6156)
  build: update to 11.1 (NG-ZORRO#6365)
  chore: sync ant-design v4.10.3 (NG-ZORRO#6364)
  feat(module:table): support nzPaginationType property (NG-ZORRO#5986)
  feat(module:date-picker): support nzId (NG-ZORRO#6242) (NG-ZORRO#6246)
  feat(module:upload): support `NzUploadFile` parameter of `nzIconRender` (NG-ZORRO#6283)
  feat(module:modal): add nzCentered for modal (NG-ZORRO#6333)
  chore: sync ant-design v4.10.2 (NG-ZORRO#6334)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants