Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:date-picker): add nzShowNow #6160

Merged
merged 3 commits into from Dec 15, 2020

Conversation

C-racker
Copy link
Contributor

@C-racker C-racker commented Dec 8, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #6146

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Dec 8, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #6160 (08a28f4) into master (13f2281) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6160      +/-   ##
==========================================
+ Coverage   89.81%   89.87%   +0.05%     
==========================================
  Files         468      468              
  Lines       14258    14257       -1     
  Branches     2243     2242       -1     
==========================================
+ Hits        12806    12813       +7     
+ Misses        896      887       -9     
- Partials      556      557       +1     
Impacted Files Coverage Δ
...mponents/date-picker/date-range-popup.component.ts 91.86% <ø> (ø)
...omponents/date-picker/calendar-footer.component.ts 95.83% <100.00%> (+0.18%) ⬆️
components/date-picker/date-picker.component.ts 92.61% <100.00%> (+0.04%) ⬆️
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
components/upload/upload-list.component.ts 95.83% <0.00%> (-0.14%) ⬇️
components/select/select.component.ts 87.62% <0.00%> (-0.13%) ⬇️
components/modal/utils.ts 100.00% <0.00%> (ø)
components/modal/modal-types.ts 100.00% <0.00%> (ø)
components/button/button.component.ts 100.00% <0.00%> (ø)
components/modal/modal-footer.component.ts 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13f2281...08a28f4. Read the comment docs.

Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试用例加一个

@wenqi73
Copy link
Member

wenqi73 commented Dec 15, 2020

Thanks for your work! @C-racker

@wenqi73 wenqi73 merged commit 99e3117 into NG-ZORRO:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants