Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:button): only warn about deprecated value when used #6193

Merged
merged 1 commit into from Dec 15, 2020

Conversation

Airblader
Copy link
Collaborator

@Airblader Airblader commented Dec 14, 2020

Only warn about the deprecated nzType="danger" value if that value
is actually used rather than any value for nzType.

fixes #6191
fixes #6187

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #6191

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Only warn about the deprecated nzType="danger" value if that value
is actually used rather than any value for nzType.

fixes NG-ZORRO#6191
@zorro-bot
Copy link

zorro-bot bot commented Dec 14, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #6193 (d652246) into master (8b92cac) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6193      +/-   ##
==========================================
- Coverage   89.84%   89.80%   -0.04%     
==========================================
  Files         468      468              
  Lines       14262    14262              
  Branches     2242     2242              
==========================================
- Hits        12813    12808       -5     
- Misses        894      899       +5     
  Partials      555      555              
Impacted Files Coverage Δ
components/button/button.component.ts 100.00% <100.00%> (ø)
components/table/src/table-data.service.ts 78.46% <0.00%> (-6.16%) ⬇️
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/time-picker/time-holder.ts 95.78% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b92cac...d652246. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 40c644a into NG-ZORRO:master Dec 15, 2020
yangjunhan pushed a commit to yangjunhan/ng-zorro-antd that referenced this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants