Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:image): image fit content when drag released #6262

Merged
merged 1 commit into from Dec 30, 2020

Conversation

stygian-desolator
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

image will fit content when drag released

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Dec 25, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 25, 2020

Codecov Report

Merging #6262 (820c5c7) into master (6b056b9) will increase coverage by 0.04%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6262      +/-   ##
==========================================
+ Coverage   89.79%   89.84%   +0.04%     
==========================================
  Files         477      478       +1     
  Lines       15186    15227      +41     
  Branches     2298     2311      +13     
==========================================
+ Hits        13636    13680      +44     
+ Misses        951      943       -8     
- Partials      599      604       +5     
Impacted Files Coverage Δ
components/image/image-preview.component.ts 90.13% <76.92%> (+2.27%) ⬆️
components/image/utils.ts 89.65% <89.65%> (ø)
components/tabs/tab-nav-bar.component.ts 83.09% <0.00%> (+1.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b056b9...820c5c7. Read the comment docs.

@stygian-desolator stygian-desolator force-pushed the fix/image-fit-content branch 3 times, most recently from f074548 to b4c6007 Compare December 25, 2020 19:27
@stygian-desolator
Copy link
Collaborator Author

@hsuanxyz cc, thanks~

@stygian-desolator
Copy link
Collaborator Author

wait

@stygian-desolator
Copy link
Collaborator Author

@hsuanxyz cc, thanks~

components/image/utils.ts Outdated Show resolved Hide resolved
@stygian-desolator
Copy link
Collaborator Author

Please review again, thanks~
But I'm a little confused, why corecov/patch failed 🤔

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, The codecov's baseline may be broken, you don't have to worry, it doesn't stop us from merge it .

@hsuanxyz hsuanxyz merged commit 07ae66a into NG-ZORRO:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants