Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:carousel): remove unused patch style #6269

Merged
merged 1 commit into from Dec 31, 2020

Conversation

stygian-desolator
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

close #6268

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #6269 (93edd74) into master (94c72be) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6269   +/-   ##
=======================================
  Coverage   89.79%   89.79%           
=======================================
  Files         477      477           
  Lines       15186    15186           
  Branches     2298     2298           
=======================================
+ Hits        13636    13637    +1     
+ Misses        951      949    -2     
- Partials      599      600    +1     
Impacted Files Coverage Δ
components/time-picker/time-holder.ts 94.73% <0.00%> (-1.06%) ⬇️
components/tabs/tab-nav-bar.component.ts 82.39% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94c72be...93edd74. Read the comment docs.

@stygian-desolator
Copy link
Collaborator Author

@hsuanxyz fix updating to 11 , please review it~ thanks~

@yangjunhan yangjunhan self-requested a review December 31, 2020 08:42
@yangjunhan
Copy link
Contributor

LGTM~

@yangjunhan yangjunhan merged commit 3a70a2d into NG-ZORRO:master Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carousel error after updating to 11.x
2 participants