Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:collapse): animation cannot be disabled #6280

Merged
merged 1 commit into from Dec 30, 2020

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Dec 29, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #6280 (c4f6696) into master (94c72be) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6280      +/-   ##
==========================================
+ Coverage   89.79%   89.80%   +0.01%     
==========================================
  Files         477      477              
  Lines       15186    15187       +1     
  Branches     2298     2298              
==========================================
+ Hits        13636    13639       +3     
+ Misses        951      949       -2     
  Partials      599      599              
Impacted Files Coverage Δ
components/collapse/collapse.module.ts 100.00% <ø> (ø)
components/collapse/collapse-panel.component.ts 93.10% <100.00%> (+0.24%) ⬆️
components/tabs/tab-nav-bar.component.ts 82.39% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94c72be...c4f6696. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 16fa890 into NG-ZORRO:master Dec 30, 2020
@hsuanxyz hsuanxyz deleted the fix/collapse branch December 30, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant