Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:carousel): fix carousel under rtl #6336

Merged
merged 1 commit into from Jan 18, 2021

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 12, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@wzhudev
Copy link
Member Author

wzhudev commented Jan 12, 2021

@hsuanxyz 我看了一下 React 版本,carousel 的滚动方向还是不变的,这里好像不太需要改 transform strategy

@zorro-bot
Copy link

zorro-bot bot commented Jan 12, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #6336 (f65d974) into master (4711194) will decrease coverage by 0.03%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6336      +/-   ##
==========================================
- Coverage   89.92%   89.88%   -0.04%     
==========================================
  Files         478      478              
  Lines       15250    15261      +11     
  Branches     2318     2320       +2     
==========================================
+ Hits        13713    13718       +5     
- Misses        924      928       +4     
- Partials      613      615       +2     
Impacted Files Coverage Δ
components/carousel/carousel.component.ts 89.24% <40.00%> (-3.38%) ⬇️
components/carousel/strategies/base-strategy.ts 83.87% <100.00%> (+0.53%) ⬆️
...mponents/carousel/strategies/transform-strategy.ts 90.00% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4711194...f65d974. Read the comment docs.

@hsuanxyz
Copy link
Member

@hsuanxyz 我看了一下 React 版本,carousel 的滚动方向还是不变的,这里好像不太需要改 transform strategy

问题就是 React 的动画 ltr,但是下面的导航条是 rtl。可以参考一下

RTL Demo | Owl Carousel | 2.3.4
Carousel

@hsuanxyz
Copy link
Member

@wendellhu95 还有一个问题是 React 在使用手势时和点击导航条的方向是反的

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 先这样和 React 保持一致吧,免得样式同步起来麻烦

@hsuanxyz hsuanxyz merged commit f6a844b into NG-ZORRO:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants