feat(module: all): global config for backdrop #6380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirelyl
requested review from
hsuanxyz,
vthinkxie,
wzhudev and
wenqi73
as code owners
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #6380 +/- ##
==========================================
+ Coverage 89.82% 89.92% +0.10%
==========================================
Files 478 479 +1
Lines 15314 15360 +46
Branches 2475 2339 -136
==========================================
+ Hits 13756 13813 +57
+ Misses 940 928 -12
- Partials 618 619 +1
Continue to review full report at Codecov.
|
tirelyl
force-pushed
the
feat/backdrop-global-config
branch
from
868e7c6
to
066f1cb
Compare
wenqi73
reviewed
Jan 26, 2021
components/popconfirm/popconfirm.ts
Outdated
| @@ -54,6 +59,7 @@ export class NzPopconfirmDirective extends NzTooltipBaseDirective { | |||
| @Input('nzPopconfirmOverlayClassName') overlayClassName?: string; | |||
| @Input('nzPopconfirmOverlayStyle') overlayStyle?: NgStyleInterface; | |||
| @Input('nzPopconfirmVisible') visible?: boolean; | |||
| @Input('nzPopconfirmBackDrop') hasBackdrop?: boolean; | |||
There was a problem hiding this comment.
Suggested change
| @Input('nzPopconfirmBackDrop') hasBackdrop?: boolean; | |
| @Input() @WithConfig() nzPopconfirmBackdrop?: boolean; |
There was a problem hiding this comment.
constructor 需要传 NzConfigService
wenqi73
reviewed
Jan 26, 2021
components/popconfirm/popconfirm.ts
Outdated
Comment on lines
91
to
99
| protected updateConfig(): void { | ||
| this.config = { | ||
| ...NZ_POPCONFIRM_DEFAULT_CONFIG, | ||
| ...this.nzConfigService?.getConfigForComponent('popconfirm') | ||
| }; | ||
| const { nzPopconfirmBackdrop } = this.config; | ||
| this.hasBackdrop = this.hasBackdrop === undefined ? nzPopconfirmBackdrop : false; | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| protected updateConfig(): void { | |
| this.config = { | |
| ...NZ_POPCONFIRM_DEFAULT_CONFIG, | |
| ...this.nzConfigService?.getConfigForComponent('popconfirm') | |
| }; | |
| const { nzPopconfirmBackdrop } = this.config; | |
| this.hasBackdrop = this.hasBackdrop === undefined ? nzPopconfirmBackdrop : false; | |
| } |
wenqi73
reviewed
Jan 26, 2021
| @@ -82,6 +88,15 @@ export class NzPopconfirmDirective extends NzTooltipBaseDirective { | |||
| }; | |||
There was a problem hiding this comment.
getProxyPropertyMap(): PropertyMapping {
return {
...
hasBackdrop: ['nzBackdrop', () => this.nzPopconfirmBackdrop]
};
}
tirelyl
force-pushed
the
feat/backdrop-global-config
branch
from
066f1cb
to
ce7d35b
Compare
tirelyl
force-pushed
the
feat/backdrop-global-config
branch
from
ce7d35b
to
57da6f0
Compare
tirelyl
changed the title
tirelyl
force-pushed
the
feat/backdrop-global-config
branch
from
6ee51a7
to
ccd9ea8
Compare
tirelyl
force-pushed
the
feat/backdrop-global-config
branch
from
ccd9ea8
to
9186f6e
Compare
wenqi73
reviewed
Mar 15, 2021
| @@ -38,6 +38,8 @@ import { NzPopconfirmModule } from 'ng-zorro-antd/popconfirm'; | |||
| | `[nzPopconfirmMouseLeaveDelay]` | 鼠标移出后延时多少才隐藏确认框，单位：秒 | `number` | `0.1` | | |||
| | `[nzPopconfirmOverlayClassName]` | 卡片类名 | `string` | - | | |||
| | `[nzPopconfirmOverlayStyle]` | 卡片样式 | `object` | - | | |||
| | `[nzPopconfirmBackdrop]` | 浮层是否应带有背景板 | `boolean` | `false` | | |||
| | `[nzPopconfirmBackdrop]` | whether or not the overlay should attach a backdrop | `boolean` | `false` | | |||
There was a problem hiding this comment.
Suggested change
| | `[nzPopconfirmBackdrop]` | whether or not the overlay should attach a backdrop | `boolean` | `false` | |
3 tasks
tirelyl
force-pushed
the
feat/backdrop-global-config
branch
from
9186f6e
to
78a229d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information