Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:descriptions): fix dom structure under vertical layout #6513

Merged

Conversation

stygian-desolator
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

close #6512

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Mar 12, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #6513 (d24e5bd) into master (c2f44be) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6513   +/-   ##
=======================================
  Coverage   89.86%   89.86%           
=======================================
  Files         479      479           
  Lines       15323    15323           
  Branches     2333     2333           
=======================================
  Hits        13770    13770           
  Misses        935      935           
  Partials      618      618           
Impacted Files Coverage Δ
components/descriptions/descriptions.component.ts 100.00% <ø> (ø)
components/tabs/tab-nav-bar.component.ts 83.09% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2f44be...f24be4f. Read the comment docs.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@vthinkxie vthinkxie merged commit ef0f3a5 into NG-ZORRO:master Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-description with vertical layout has a space between the column and the title
3 participants