Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:drawer): content is attached before the drawer is opened #6581

Merged
merged 1 commit into from Apr 8, 2021

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Apr 8, 2021

fix #6381, close #6534

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #6381

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 8, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #6581 (84694e3) into master (21ded3f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 84694e3 differs from pull request most recent head bfe26a3. Consider uploading reports for the commit bfe26a3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6581   +/-   ##
=======================================
  Coverage   89.92%   89.92%           
=======================================
  Files         481      481           
  Lines       15375    15381    +6     
  Branches     2344     2344           
=======================================
+ Hits        13826    13832    +6     
  Misses        929      929           
  Partials      620      620           
Impacted Files Coverage Δ
components/drawer/drawer.component.ts 97.08% <100.00%> (-0.92%) ⬇️
components/time-picker/time-holder.ts 95.78% <0.00%> (+1.05%) ⬆️
components/drawer/drawer-content.directive.ts 100.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21ded3f...bfe26a3. Read the comment docs.

@hsuanxyz hsuanxyz merged commit ac50a7b into NG-ZORRO:master Apr 8, 2021
@hsuanxyz hsuanxyz deleted the fix/drawer-lay branch April 8, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drawer抽屉嵌套组件(内含抽屉)多重打开第一层会遮挡最后打开的抽屉弹层
1 participant