Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:core): support reset NZ_CONFIG inside component & overflow component #6601

Merged
merged 5 commits into from Jun 16, 2021

Conversation

vthinkxie
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 13, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #6601 (b878f51) into master (923f14e) will decrease coverage by 0.12%.
The diff coverage is 56.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6601      +/-   ##
==========================================
- Coverage   89.70%   89.58%   -0.13%     
==========================================
  Files         486      488       +2     
  Lines       15757    15777      +20     
  Branches     2564     2568       +4     
==========================================
- Hits        14135    14134       -1     
- Misses        980     1002      +22     
+ Partials      642      641       -1     
Impacted Files Coverage Δ
...nts/cdk/resize-observer/resize-observer.service.ts 73.68% <ø> (ø)
components/date-picker/date-picker.component.ts 90.97% <ø> (ø)
components/page-header/page-header.component.ts 85.00% <ø> (ø)
components/table/src/table.module.ts 100.00% <ø> (ø)
components/table/src/table/table.component.ts 90.32% <ø> (ø)
components/table/src/table/tr-measure.component.ts 86.95% <ø> (-13.05%) ⬇️
components/tabs/tab-nav-bar.component.ts 83.03% <ø> (ø)
...s/cdk/resize-observer/resize-observer.directive.ts 28.57% <28.57%> (ø)
components/core/config/config.service.ts 91.17% <62.50%> (-5.89%) ⬇️
components/select/select.component.ts 87.22% <77.77%> (-0.05%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 923f14e...b878f51. Read the comment docs.

@vthinkxie vthinkxie force-pushed the refactor-all branch 5 times, most recently from 99a77a7 to 3621133 Compare April 15, 2021 08:40
NzConfigService,
{
provide: NZ_CONFIG,
useFactory: (nzConfigService: NzConfigService) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果之后用户对父级的 NzConfigService 做出了修改,例如调用 set 方法更新某个 config,这样不会被传递到子级的 NzConfigService 去。

还是说这里就是想要做成这样子呢?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯,不会生效,我在文档中再说明一下

@vthinkxie vthinkxie changed the title feat(module:config): support reset NZ_CONFIG inside component feat(module:*): support reset NZ_CONFIG inside component & overflow component Jun 16, 2021
@vthinkxie vthinkxie mentioned this pull request Jun 16, 2021
15 tasks
@vthinkxie vthinkxie changed the title feat(module:*): support reset NZ_CONFIG inside component & overflow component feat(module:core): support reset NZ_CONFIG inside component & overflow component Jun 16, 2021
Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit edd410a into NG-ZORRO:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants