New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:core): support reset NZ_CONFIG inside component & overflow component #6601
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #6601 +/- ##
==========================================
- Coverage 89.70% 89.58% -0.13%
==========================================
Files 486 488 +2
Lines 15757 15777 +20
Branches 2564 2568 +4
==========================================
- Hits 14135 14134 -1
- Misses 980 1002 +22
+ Partials 642 641 -1
Continue to review full report at Codecov.
|
99a77a7
to
3621133
Compare
NzConfigService, | ||
{ | ||
provide: NZ_CONFIG, | ||
useFactory: (nzConfigService: NzConfigService) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果之后用户对父级的 NzConfigService 做出了修改,例如调用 set 方法更新某个 config,这样不会被传递到子级的 NzConfigService 去。
还是说这里就是想要做成这样子呢?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯,不会生效,我在文档中再说明一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information