Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:datepicker): fixed opacity 0 on inline datepicker reopen #6910

Merged
merged 3 commits into from Aug 9, 2021

Conversation

nikolatasikj
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

#6897

Issue Number: 6897

What is the new behavior?

There is no animation for inline mode datepicker so it's not going invisible after re-opening

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Inline datepicker don't need to have animation because it's inline, nothing is opened through dropdown. Problems was in animation attached to inline mode so it's going to make opacity: 0 on inline datepicker after re-opening

@zorro-bot
Copy link

zorro-bot bot commented Aug 5, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #6910 (69646ad) into master (f5d1de3) will not change coverage.
The diff coverage is n/a.

❗ Current head 69646ad differs from pull request most recent head 3a6ed64. Consider uploading reports for the commit 3a6ed64 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6910   +/-   ##
=======================================
  Coverage   89.50%   89.50%           
=======================================
  Files         489      489           
  Lines       15805    15805           
  Branches     2428     2428           
=======================================
  Hits        14147    14147           
  Misses       1016     1016           
  Partials      642      642           
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 90.97% <ø> (ø)
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/tabs/tab-nav-bar.component.ts 83.03% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5d1de3...3a6ed64. Read the comment docs.

Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    <ng-template
      cdkConnectedOverlay
      nzConnectedOverlay
      [cdkConnectedOverlayHasBackdrop]="nzBackdrop"
      [cdkConnectedOverlayOrigin]="origin"
      [cdkConnectedOverlayOpen]="realOpenState"
      [cdkConnectedOverlayPositions]="overlayPositions"
      [cdkConnectedOverlayTransformOriginOn]="'.ant-picker-wrapper'"
      (positionChange)="onPositionChange($event)"
      (detach)="close()"
      (overlayKeydown)="onOverlayKeydown($event)"
    >
      <div
        class="ant-picker-wrapper"
        [nzNoAnimation]="!!noAnimation?.nzNoAnimation"
        [@slideMotion]="'enter'"
        style="position: relative;"
      >
        <ng-container *ngTemplateOutlet="inlineMode"></ng-container>
      </div>
    </ng-template>

@wenqi73 wenqi73 merged commit d392b2e into NG-ZORRO:master Aug 9, 2021
@wenqi73
Copy link
Member

wenqi73 commented Aug 9, 2021

close #6897.
Thanks @nikolatasikj !

@nikolatasikj nikolatasikj deleted the fix/inline-mode-reopen branch August 10, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants