Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:timepicker): fix auto positioning picker #6939

Merged
merged 1 commit into from Oct 25, 2021

Conversation

KeelanS
Copy link
Contributor

@KeelanS KeelanS commented Aug 23, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 6034

What is the new behavior?

The picker changes position depending on how much space there is.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Aug 23, 2021

This preview will be available after the AzureCI is passed.

@KeelanS KeelanS changed the title fix(module:timepicker): fixed auto positioning picker fix(module:timepicker): fix auto positioning picker Aug 23, 2021
@KeelanS
Copy link
Contributor Author

KeelanS commented Aug 23, 2021

I don't think tests are needed here. If they are, please guide me to another module that does test this because I have no idea how I would do this. :)

@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #6939 (df74033) into master (d392b2e) will not change coverage.
The diff coverage is n/a.

❗ Current head df74033 differs from pull request most recent head 02ddca2. Consider uploading reports for the commit 02ddca2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6939   +/-   ##
=======================================
  Coverage   89.50%   89.50%           
=======================================
  Files         489      489           
  Lines       15805    15805           
  Branches     2428     2428           
=======================================
  Hits        14146    14146           
  Misses       1016     1016           
  Partials      643      643           
Impacted Files Coverage Δ
components/time-picker/time-picker.component.ts 85.18% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d392b2e...02ddca2. Read the comment docs.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason
Copy link
Member

fixed #6034

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants