Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:table): resolve leak within the nz-table-fixed-row #7034

Merged
merged 1 commit into from Nov 4, 2021

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Nov 3, 2021

PR Checklist

PR Type

What kind of change does this PR introduce?

[x] Bugfix

What is the current behavior?

The hostWidth$ subject keeps the NzTableFixedRowComponent.hostWidth$ within its observers property until it unsubscribes.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@zorro-bot
Copy link

zorro-bot bot commented Nov 3, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #7034 (3c3e56a) into master (b18c050) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7034      +/-   ##
==========================================
- Coverage   89.52%   89.51%   -0.02%     
==========================================
  Files         489      489              
  Lines       15768    15768              
  Branches     2573     2433     -140     
==========================================
- Hits        14117    14114       -3     
- Misses       1011     1012       +1     
- Partials      640      642       +2     
Impacted Files Coverage Δ
...nents/table/src/table/table-fixed-row.component.ts 93.75% <100.00%> (ø)
components/core/util/text-measure.ts 89.47% <0.00%> (-1.76%) ⬇️
components/time-picker/time-holder.ts 95.78% <0.00%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b18c050...3c3e56a. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit cfa1ecd into NG-ZORRO:master Nov 4, 2021
@arturovt arturovt deleted the fix/table-fixed-row-leak branch November 4, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants