New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:button): fix add class ant-btn-icon-only(#7631) #7678
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7678 +/- ##
=======================================
Coverage 91.78% 91.78%
=======================================
Files 509 509
Lines 17444 17434 -10
Branches 2772 2681 -91
=======================================
- Hits 16011 16002 -9
Misses 1134 1134
+ Partials 299 298 -1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
any plan to merge this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to be. But a unit test would be good. :) @withOutUndo could you please add one?
add some tests for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
when would this be merged? |
@simplejason This could be merged in the next patch version. |
Dear developers, please merge this already 🙏 Apps that dynamically load nz icons have been broken for a long while because of this. I've been waiting months for a fix so I can upgrade to the new version. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: 7631
What is the new behavior?
add class
ant-btn-icon-only
to buttonDoes this PR introduce a breaking change?