Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:button): fix add class ant-btn-icon-only(#7631) #7678

Merged
merged 3 commits into from Sep 18, 2023
Merged

fix(module:button): fix add class ant-btn-icon-only(#7631) #7678

merged 3 commits into from Sep 18, 2023

Conversation

withOutUndo
Copy link
Contributor

@withOutUndo withOutUndo commented Oct 14, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 7631

What is the new behavior?

add class ant-btn-icon-only to button

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #7678 (b62a22c) into master (538ef21) will increase coverage by 0.00%.
The diff coverage is 83.33%.

❗ Current head b62a22c differs from pull request most recent head bf01358. Consider uploading reports for the commit bf01358 to get more accurate results

@@           Coverage Diff           @@
##           master    #7678   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files         509      509           
  Lines       17444    17434   -10     
  Branches     2772     2681   -91     
=======================================
- Hits        16011    16002    -9     
  Misses       1134     1134           
+ Partials      299      298    -1     
Impacted Files Coverage Δ
components/button/button.component.ts 98.52% <83.33%> (+1.09%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sebcam
Copy link
Contributor

sebcam commented Feb 15, 2023

any plan to merge this ?

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to be. But a unit test would be good. :) @withOutUndo could you please add one?

@withOutUndo
Copy link
Contributor Author

The code looks good to be. But a unit test would be good. :) @withOutUndo could you please add one?

add some tests for this

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@Zaleck-a
Copy link

Zaleck-a commented Jun 5, 2023

when would this be merged?

@wzhudev
Copy link
Member

wzhudev commented Jun 7, 2023

@simplejason This could be merged in the next patch version.

@igorbremec
Copy link

Dear developers, please merge this already 🙏

Apps that dynamically load nz icons have been broken for a long while because of this. I've been waiting months for a fix so I can upgrade to the new version.

@simplejason simplejason merged commit 7470ed6 into NG-ZORRO:master Sep 18, 2023
7 checks passed
@withOutUndo withOutUndo deleted the fix-btn-icon-only branch October 23, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants