Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:slider): step can not click the problem #7820

Merged
merged 1 commit into from Nov 17, 2023

Conversation

OriginRing
Copy link
Collaborator

fix: #7817

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 31, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4e9f876) 91.70% compared to head (aec4f25) 91.71%.
Report is 2 commits behind head on master.

❗ Current head aec4f25 differs from pull request most recent head e4db2a1. Consider uploading reports for the commit e4db2a1 to get more accurate results

Files Patch % Lines
...nents/cron-expression/cron-expression.component.ts 80.00% 1 Missing ⚠️
components/menu/menu-group.component.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7820      +/-   ##
==========================================
+ Coverage   91.70%   91.71%   +0.01%     
==========================================
  Files         517      517              
  Lines       17810    17808       -2     
  Branches     2730     2729       -1     
==========================================
  Hits        16332    16332              
+ Misses       1179     1178       -1     
+ Partials      299      298       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laffery
Copy link
Collaborator

Laffery commented Nov 17, 2023

close #7817

@Laffery Laffery closed this Nov 17, 2023
@Laffery Laffery reopened this Nov 17, 2023
@Laffery Laffery merged commit 1e1c753 into NG-ZORRO:master Nov 17, 2023
7 checks passed
@OriginRing OriginRing deleted the fix/sliderStepClick branch March 8, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng-zorro slider bullet point
2 participants