fix(module:message): clean up DOM after usage #7965
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call
overlayRef.dispose()
when all instances of messages have disappearedResolves #7772
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
The current implementation of the message service leaves a
nz-message-container
element in the DOM even after all messages have been removed. This PR introduces a small change so that the DOM is cleaned up when all messages are removed, so no extra elements remain in the DOMWhat is the current behavior?
Issue Number: #7772
What is the new behavior?
Does this PR introduce a breaking change?
Other information