Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:qrcode): optimize demo display and nzPadding value #8020

Merged
merged 1 commit into from Jul 18, 2023

Conversation

OriginRing
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jul 18, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #8020 (85c5a29) into master (544f308) will increase coverage by 0.00%.
The diff coverage is 85.71%.

❗ Current head 85c5a29 differs from pull request most recent head 68e7438. Consider uploading reports for the commit 68e7438 to get more accurate results

@@           Coverage Diff           @@
##           master    #8020   +/-   ##
=======================================
  Coverage   91.64%   91.65%           
=======================================
  Files         515      515           
  Lines       17637    17641    +4     
  Branches     2789     2790    +1     
=======================================
+ Hits        16164    16169    +5     
  Misses       1175     1175           
+ Partials      298      297    -1     
Impacted Files Coverage Δ
components/qr-code/qrcode.component.ts 90.69% <85.71%> (-1.62%) ⬇️

... and 1 file with indirect coverage changes

@simplejason simplejason merged commit 078aaf9 into NG-ZORRO:master Jul 18, 2023
7 checks passed
@OriginRing OriginRing deleted the fix/qrcode branch March 8, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants