Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:core): resolve CSP errors #8059

Merged
merged 1 commit into from Sep 18, 2023

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Aug 17, 2023

The ConfigService needs to insert a style tag when registering theme. These changes use the new CSP_NONCE token to avoid CSP issues.

Closes #7644

The `ConfigService` needs to insert a `style` tag when registering theme. These changes use
the new `CSP_NONCE` token to avoid CSP issues.
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #8059 (c798a88) into master (7f7c155) will increase coverage by 0.00%.
The diff coverage is 76.92%.

❗ Current head c798a88 differs from pull request most recent head 494b959. Consider uploading reports for the commit 494b959 to get more accurate results

@@           Coverage Diff           @@
##           master    #8059   +/-   ##
=======================================
  Coverage   91.64%   91.65%           
=======================================
  Files         515      515           
  Lines       17640    17645    +5     
  Branches     2790     2791    +1     
=======================================
+ Hits        16167    16172    +5     
  Misses       1175     1175           
  Partials      298      298           
Files Changed Coverage Δ
components/core/util/dynamic-css.ts 72.00% <64.28%> (ø)
components/core/wave/nz-wave-renderer.ts 95.94% <75.00%> (-1.24%) ⬇️
components/core/config/config.service.ts 100.00% <100.00%> (ø)
components/core/config/css-variables.ts 87.23% <100.00%> (ø)
components/core/wave/nz-wave.directive.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@simplejason simplejason merged commit 295b333 into NG-ZORRO:master Sep 18, 2023
7 checks passed
@arturovt arturovt deleted the fix/core-csp branch September 18, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content Security Policy (CSP) Support
4 participants