New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:upload): remove inline style to resolve CSP issue #8064
Conversation
This preview will be available after the AzureCI is passed. |
653eced
to
9abbc51
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8064 +/- ##
==========================================
- Coverage 91.74% 91.62% -0.13%
==========================================
Files 520 530 +10
Lines 18023 18391 +368
Branches 2838 2815 -23
==========================================
+ Hits 16536 16851 +315
- Misses 1184 1224 +40
- Partials 303 316 +13 ☔ View full report in Codecov by Sentry. |
9abbc51
to
8aa89f8
Compare
We should not add the new style directly to the antd style file, as this will interfere with the component style synchronization. We can either add the style to |
This commit addresses the CSP issue by removing the inline `style` property from the `input` element within the `nz-upload` component. The use of inline style attributes necessitates the inclusion of `unsafe-inline`.
8aa89f8
to
6864915
Compare
Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit addresses the CSP issue by removing the inline
style
property from theinput
element within thenz-upload
component. The use of inline style attributes necessitates the inclusion ofunsafe-inline
.